testing unverified commit #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated testbed * Update cleanConfig.yml Added new line * Update cleanConfig_sit.yml
* QUAGGA_CONFIG update QUAGGA_CONFIG there is no policy (route-map) defined for peer-group IXIA. Due to that it is not able to receive routes In/Out. If we add “no bgp ebgp-requires-policy”, it advertises and receives the routes from other peers and traffic flows fine. * print ixia app error log added code to print ixia error log when start_protocols stop_protocols --------- Co-authored-by: vkuma82 <kumarvinod82@yahoo.com>
Signed-off-by: hubogee <hubogee@gmail.com>
Signed-off-by: hubogee <hubogee@gmail.com>
Fixed stage result settings
joannalye
commented
Nov 11, 2025
joannalye
commented
Nov 11, 2025
| self.log.info('Verify if cloned repo test branch has files in it') | ||
| output = Utilities.runLinuxCmd('ls', cwd=self.testIdTestingBranch, logObj=self.log) | ||
| if len(output) > 0: | ||
| self.log.info('Verified cloned files!') |
Owner
Author
There was a problem hiding this comment.
In my opinion that could make it harder for PR owner to go over the code comments when addressing them as they'd have to open them one by one.
On the other hand, as a reviewer I might want to collapse all comments to focus on reading the code and only open comments to see if someone already commented the same thing at the same code location before adding a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.