add support for non-binary sensors

Author: joelhawksley

app/apis/home_assistant_api.rb

@@ -17,21 +17,29 @@ def prepare_response(response)
     response.filter do
       entity_ids.include?(_1["entity_id"]) ||
         _1.dig("attributes", "device_class") == "battery" ||
-        _1["entity_id"].include?("binary_sensor.timeframe")
+        _1["entity_id"].include?("sensor.timeframe")
     end
   end
 
   def problems
     data
-      .select { _1[:entity_id].include?("binary_sensor.timeframe") && _1[:state] == "on" }
-      .map { _1[:entity_id] }
-      .map do |entity_id|
-        _, icon, raw_message = entity_id.split("0")
-
-        {
-          icon: icon.tr("_", "-"),
-          message: raw_message.tr("_", " ").humanize
-        }
+      .select { _1[:entity_id].include?("sensor.timeframe") }
+      .map do
+        if _1[:state] == "on"
+          _, icon, raw_message = _1[:entity_id].split("0")
+
+          {
+            icon: icon.tr("_", "-"),
+            message: raw_message.tr("_", " ").humanize
+          }
+        elsif !["on", "off", ""].include?(_1[:state])
+          _, icon, _ = _1[:entity_id].split("0")
+
+          {
+            icon: icon.tr("_", "-"),
+            message: _1[:state]
+          }
+        end
       end
   end
 

test/apis/home_assistant_api_test.rb

@@ -370,4 +370,13 @@ def test_problems
       assert_equal(api.problems, [{icon: "print", message: "Printer ink low"}])
     end
   end
+
+  def test_problems_non_binary
+    data = [{entity_id: "sensor.timeframe0print0printer_ink_low", state: "Ink low"}]
+
+    api = HomeAssistantApi.new({})
+    api.stub :data, data do
+      assert_equal(api.problems, [{icon: "print", message: "Ink low"}])
+    end
+  end
 end