Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in docs and var name #130

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/content/community.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: "Community"
description: Contrubutions from the community.
description: Contributions from the community.
linkTitle: "Community"
menu: { main: { weight: 11 } }
---
Expand Down
2 changes: 1 addition & 1 deletion doc/content/task-syntax/requires.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The `requires` attribute can be used to define tasks that should be run prior to

For example, you want to run a task to deploy your code, but you want to run all the unit tests and linters before that happens.

Before the command section of the task, you may define comma seperated dependencies with `requires:` or `req:` followed by the name of the tasks that are dependencies.
Before the command section of the task, you may define comma separated dependencies with `requires:` or `req:` followed by the name of the tasks that are dependencies.

````markdown
## Tasks
Expand Down
2 changes: 1 addition & 1 deletion doc/content/task-syntax/run-deps.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ menu: { main: { parent: "task-syntax", weight: 11 } }
## RunDeps attribute

By default, the dependencies of a task are run sequentially, in the order they are listed.
However we may prefer for all the dependencies of a task to be run in paralled.
However we may prefer for all the dependencies of a task to be run in parallel.

The solution would be to set the `RunDeps` attribute to `async` (defaults to `sync`).

Expand Down
2 changes: 1 addition & 1 deletion parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ const (
// AttributeTypeInp sets the required inputs for a Task, inputs can be provided
// as commandline arguments or environment variables.
AttributeTypeInp
// AttrubuteTypeRun sets the tasks requiredBehaviour, can be always or once.
// AttributeTypeRun sets the tasks requiredBehaviour, can be always or once.
// Default is always
AttributeTypeRun
// AttributeTypeRunDeps sets the tasks dependenciesBehaviour, can be sync or async.
Expand Down
8 changes: 4 additions & 4 deletions run/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type Runner struct {
tasks models.Tasks
dir string
alreadyRan map[string]bool
alreadRanMu sync.Mutex
alreadyRanMu sync.Mutex
}

// NewRunner takes Tasks and returns a Runner.
Expand Down Expand Up @@ -112,14 +112,14 @@ func (r *Runner) runWithPadding(ctx context.Context, name string, inputs []strin
if !ok {
return fmt.Errorf("task %s not found", name)
}
r.alreadRanMu.Lock()
r.alreadyRanMu.Lock()
if task.RequiredBehaviour == models.RequiredBehaviourOnce && r.alreadyRan[task.Name] {
r.alreadRanMu.Unlock()
r.alreadyRanMu.Unlock()
fmt.Printf("task %q ran already: skipping\n", task.Name)
return nil
}
r.alreadyRan[task.Name] = true
r.alreadRanMu.Unlock()
r.alreadyRanMu.Unlock()
env := os.Environ()
env = append(env, task.Env...)
inp, err := getInputs(task, inputs, env)
Expand Down
Loading