Closed
Conversation
Contributor
Author
|
Seems to be running just fine on the watch. The main thing I hadn't been able to test in the emulator was low power mode. |
WesleyAC
previously requested changes
Nov 19, 2023
Collaborator
WesleyAC
left a comment
WesleyAC
left a comment
There was a problem hiding this comment.
Very cool! Just a couple changes needed :)
Contributor
Author
Thanks so much for this and all of the other reviews, @WesleyAC ! I'll make those changes soon. 👍 |
Contributor
Author
|
Well, that took way longer to get around to than it should have. All fixed up, and upstream merged! Thanks again, @WesleyAC. Great catches. |
theAlexes
approved these changes
Sep 7, 2024
matheusmoreira
added
enhancement
matheusmoreira
approved these changes
Sep 7, 2024
matheusmoreira
added
the
tested-on-hw
matheusmoreira
added a commit
that referenced
this pull request
Sep 7, 2024
Adds a french revolutionary time watch face which displays the time divided into ten hours of one hundred minutes each which are in turn divided into one hundred seconds each. Reviewed-by: Matheus Afonso Martins Moreira <matheus@matheusmoreira.com> Reviewed-by: Wesley Aptekar-Cassels <me@wesleyac.com> Reviewed-by: Alex Maestas <git@se30.xyz> Tested-on-hardware-by: CarpeNoctem <cryptomax@pm.me> GitHub-Pull-Request: #269
matheusmoreira
added
the
next
matheusmoreira
added a commit
that referenced
this pull request
Sep 7, 2024
Adds a french revolutionary time watch face which displays the time divided into ten hours of one hundred minutes each which are in turn divided into one hundred seconds each. Reviewed-by: Matheus Afonso Martins Moreira <matheus@matheusmoreira.com> Reviewed-by: Wesley Aptekar-Cassels <me@wesleyac.com> Reviewed-by: Alex Maestas <git@se30.xyz> Tested-on-hardware-by: CarpeNoctem <cryptomax@pm.me> GitHub-Pull-Request: #269
matheusmoreira
added a commit
that referenced
this pull request
Sep 7, 2024
Adds a french revolutionary time watch face which displays the time divided into ten hours of one hundred minutes each which are in turn divided into one hundred seconds each. Reviewed-by: Matheus Afonso Martins Moreira <matheus@matheusmoreira.com> Reviewed-by: Wesley Aptekar-Cassels <me@wesleyac.com> Reviewed-by: Alex Maestas <git@se30.xyz> Tested-on-hardware-by: CarpeNoctem <cryptomax@pm.me> GitHub-Pull-Request: #269
34 tasks
matheusmoreira
added
the
main
Collaborator
|
This PR has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial submission of French Revolutionary (Decimal) time face.
I've only run this on the emulator, but have just loaded it onto my watch for testing as well.I'll try to add the power-saving stuff to the output in the coming week or so.French Revolutionary Decimal Time
Similar to the Decimal Time face, but with the day divided into ten hours instead of twenty four.
Each hour is divided into one hundred minutes, and those minutes are divided into 100 seconds.
I came across this one the Svalbard watch site here: https://svalbard.watch/pages/about_decimal_time.html
More info here as well: https://en.wikipedia.org/wiki/Decimal_time
Usage
By default, the face just displays the current decimal time. Pressing the alarm button will toggle through other display options:
Sadly, the first character of the date area only goes up to 3. (see https://www.sensorwatch.net/docs/wig/display/#the-day-digits) I was going to begrudgindly leave this display option out when I realized that, but thought it would be better to have this backwards representation of the standard time than not at all.
A long-press of the light button will toggle the upper time between 12-hr AM/PM and 24-hr mode. I thought of reading the main setting for this, but thought that a person could normally prefer 12hr time, but next to a 10hr day want to see the normal time in the 24hr format.
A long-press of the alarm button will toggle the seconds off and on.