Reduce totp_face_lfs memory usage #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also interested in a merge. Do we still need ~ 3 months test period? |
|
@theAlexes Would you be able to please look at this PR. I feel this should be merged as it fixes a problematic bug and has no other changes. I have been running it on my watch for several months now. |
|
Hey there, since this is stable for the two of you, we'll merge this in. :) Sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fix from #393 separated from the new secure mode feature. The idea behind this being that this can be merged to fix #392 whilst the secure mode is being worked on.
Code is by @wryun , I have left his name as the commit author.
I have been running this on my physical red watch now for a while now with no issues. Would be good to merge this and close #392 as that bug causes a fairly concerning file system failure that requires reformatting the storage on boot to fix.