Location face #133
Open
Location face #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OM always appears when cycling
…d a time in a specific timezone
…r out cities only if tz mismatch
…at are preset are set outside of the current tz
Collaborator
Author
|
@joeycastillo , Let me know what your thoughts are on this change to sunrise/sunset face. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location Setting Face
This PR updates the Sunrise/Sunset face. Now, instead of requiring the long/lat to set the location, you can set from the most populated cities.
The face behaves exactly as it used to if your timezone is UTC.
If you have your timezone set otherwise, it'll allow you to select from a preset of cities.
The cities were chosen as the all cities with a 2025 population of at least 1,000,000 that are not within 500km of a more populated city that shares its timezone.
Since location is mainly used for sunrise data, it won't care too much if you live in Taicang, but set it to Shanghai.
The city list can be found here.
location-presets-sun.mp4