Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for this awesome piece of software. As I've started to tinker with it, I'd like to share the Dockerfile which enabled a Docker workflow for me.
Add Dockerfile to enable image building. Useful for development and tests under Docker workflow.
Using the official Python 3 image, latest tag. More info at https://hub.docker.com/_/python/
Just adding files, setting working dir and running install and build instructions.
requirements.txt
is added andpip install
'ed in a separate step to speed up rebuilds, since it will take advantage of Docker image build layer caching on subsequent builds after modifying code.Build:
Build (no checkout needed):
Run:
FYI, there's a still quicker to test,
already built imageold image on my Docker Hub. Test it by running:The examples mount the current dir inside the Docker container (
-v
) and map container's internal port to outside host (p
). Adding0.0.0.0
is required, since otherwise container'slocalhost
would not be reachable from outside (the host).Using
--rm
causes container it to be deleted after stop and-it
makes the container not to go background and run interactively. Stop byCTRL+C
'ing.Optional improvement to come (maybe in another issue):
at Docker Hub for the image: https://docs.docker.com/docker-hub/builds/. Just requires a free Docker Hub account and a separate PRfollowing a quick 'Create automated build' process. I'll be happy to help on it, if needed.