Fixed so that blocking and reactive EventStoreQueries really uses `So…

…rtBy.unsorted()` by default as was intended in the previous release.
johanhaleby · Sep 27, 2024 · 4a4a561 · 4a4a561
1 parent 16e6436
commit 4a4a561
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,6 @@
+### 0.19.5 (2024-09-27)
+* Fixed so that blocking and reactive EventStoreQueries really uses `SortBy.unsorted()` by default as was intended in the previous release.
+
 ### 0.19.4 (2024-09-27)
 * Added better debug logging
 * Improved queryOne performance in DomainEventQueries

diff --git a/...e/api/blocking/src/main/java/org/occurrent/eventstore/api/blocking/EventStoreQueries.java b/...e/api/blocking/src/main/java/org/occurrent/eventstore/api/blocking/EventStoreQueries.java
@@ -23,7 +23,6 @@
 import java.util.stream.Stream;
 
 import static java.util.Objects.requireNonNull;
-import static org.occurrent.eventstore.api.SortBy.SortDirection.ASCENDING;
 
 /**
  * Additional querying capabilities that may be supported by an {@link EventStore} implementation that is not typically part of a
@@ -72,7 +71,7 @@ default Stream<CloudEvent> query(Filter filter, SortBy sortBy) {
      * @return All cloud events matching the specified filter
      */
     default Stream<CloudEvent> query(Filter filter, int skip, int limit) {
-        return query(filter, skip, limit, SortBy.natural(ASCENDING));
+        return query(filter, skip, limit, SortBy.unsorted());
     }
 
     /**

diff --git a/...ore/api/reactor/src/main/java/org/occurrent/eventstore/api/reactor/EventStoreQueries.java b/...ore/api/reactor/src/main/java/org/occurrent/eventstore/api/reactor/EventStoreQueries.java
@@ -23,7 +23,6 @@
 import reactor.core.publisher.Mono;
 
 import static java.util.Objects.requireNonNull;
-import static org.occurrent.eventstore.api.SortBy.SortDirection.ASCENDING;
 
 /**
  * Additional querying capabilities that may be supported by an {@link EventStore} implementation that is not typically part of a
@@ -33,7 +32,7 @@ public interface EventStoreQueries {
 
     /**
      * Note that it's recommended to create an index on the "time" field in the event store in order to make
-     * {@link SortBy#TIME_ASC} and {@link SortBy#TIME_DESC} efficient.
+     * {@link SortBy} efficient.
      *
      * @return All cloud events matching the specified filter, skip, limit and sort by <code>sortBy</code>.
      */
@@ -73,7 +72,7 @@ default Flux<CloudEvent> query(Filter filter, SortBy sortBy) {
      * @return All cloud events matching the specified filter
      */
     default Flux<CloudEvent> query(Filter filter, int skip, int limit) {
-        return query(filter, skip, limit, SortBy.natural(ASCENDING));
+        return query(filter, skip, limit, SortBy.unsorted());
     }
 
     /**