sled: match redb behaviour and flush after any write #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
changed the title
|
I don't have time to test it but if it was the reason of sled not clearing up the storage would be interesting :) |
|
@johanhelsing friendly ping, can we merge this? anything you want me to change? |
johanhelsing
reviewed
Jul 8, 2024
|
Been using this now in production for months without any hiccups |
johanhelsing
approved these changes
Jul 8, 2024
|
Okay if anyone is writing huge values and it causes problems they can complain :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as i can see, the redb implementation writes off to disk after each write (which is what I would expect) and this change will make the sled implementation match that behaviour