Skip to content

Commit

Permalink
Prepare for CRAN release
Browse files Browse the repository at this point in the history
  • Loading branch information
johanneskoch94 committed Jun 5, 2024
1 parent c05803f commit 583e73a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: GDPuc
Title: Easily Convert GDP Data
Version: 1.0.0
Date: 2024-04-16
Date: 2024-06-5
Authors@R:
person("Johannes", "Koch", , "jokoch@pik-potsdam.de", role = c("aut", "cre"))
Description: Convert GDP time series data from one unit to
Expand Down
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# GDPuc 1.0.0

* Update wdi conversion factors and data
* Add the CPI as possible deflator
* Add two shortcut functions for using the CPI as deflator and convert a single value (fixed #20)
* Add example to convertGDP (fixes #21)
* Add options to convert to constant € and use only US deflator
* Add with_USA option to replace_NAs
* Relax restriction on presence of a year column (fixes #17)
* Improve order of tests
* Use magclass::as_tibble() instead of custom function

# GDPuc 0.11.1

* Clean up Suggest field, in order to comply with CRAN specifications
Expand Down
7 changes: 3 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
### Re-submission after email from Victoria Wimmer from the 17th of July
### Major update to the package

* Package description was amended following the recommendations (doesn't start with "function to").
* Missing "value" section in documentation of a function was added (the recommended "No return value, called for side effects" was used.)
* As I understand it, the package was previously archived because of the warning "Does not use Suggests conditionally". This issue was addressed, by making sure that the packages listed under "suggests" are now used conditionally in the package tests and vignettes. I do not get any warnings anymore when checking, only the "checking CRAN incoming feasibility" note, indicating that the package was archived.
* Update of the package sysdata.
* Addition of 2 quality-of-life functions, that act as shortcuts for common function calls.

### R CMD check results

Expand Down

0 comments on commit 583e73a

Please sign in to comment.