-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image transitions #56
base: main
Are you sure you want to change the base?
Conversation
added transitions!
β Deploy Preview for unlazy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Interesting! Thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if it was AI or you, but you removed a lot of features and comments. Please revert these changes and only implement the new transition feature without adding breaking changes.
Also: please add the documentation for the new feature.
Hey @johannschopplich so sorry about that! I was doing a lot of testing from before I moved from css to canvas and I had forgot to revert things back when doing that (making changes in all packages trying to get css to work before reverting to canvas) I also will bring back the comments. I did have a bot check my code for any vulnerabilities and I didn't even notice it removed all the dang comments when I did that. I'll get a new commit out soon. |
I had already updated the readme.md and the examples and totally didn't realize there was a docs directory. Getting this part done now and I think we will be all set! :) |
Thanks a lot for your feedback! |
Restore Comments, Docs, Cleanup
No Thank you! this is one of my first bigger contributions and it means a lot to get proper feedback on what I'm doing. |
ThumbHash not Thumbhash
@johannschopplich LGTM unless you notice anything else! |
Thanks for the PR! Unfortunately I haven't had time to review it yet. π₯² |
Hey no rush at all! My project isn't launching till closer to end of Q1. Take your time :) |
1.mp4
π Linked issue
#51
β Type of change
π Description
This adds optional transitions between BlurHash or ThumbHash via a new prop. It uses the Canvas API for compatibility and performance. This resolves the linked issue.