Fix #349

johnbedeir · May 20, 2024 · 8cae7c9 · 8cae7c9
1 parent f30b260
commit 8cae7c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Terraform/GCP/GKE/gke.tf b/Terraform/GCP/GKE/gke.tf
@@ -40,7 +40,6 @@ resource "google_container_node_pool" "primary_nodes" {
   node_config {
     preemptible  = false
     machine_type = "e2-medium"
-    #service_account = ""
 
     // Assign nodes to the private subnet
     tags = ["gke-node", "private-subnet"]
@@ -64,6 +63,7 @@ resource "helm_release" "cluster-autoscaler" {
     value = "true"
   }
 
+  // GKE-specific settings
   set {
     name  = "autoDiscovery.clusterName"
     value = "${var.name_prefix}-${var.environment}"

diff --git a/Terraform/GCP/GKE/variables.tf b/Terraform/GCP/GKE/variables.tf
@@ -2,23 +2,23 @@
 variable "project_id" {
   description = "The name of the VPC to use."
   type        = string
-  default     = "johnydev"
+  default     = "PROJECT_ID"
 }
 
 
 variable "region" {
   description = "The name of the VPC to use."
   type        = string
-  default     = "europe-west1"
+  default     = "REGION"
 }
 
 variable "name_prefix" {
   description = "The name of the VPC to use."
   type        = string
-  default     = "cluster-1"
+  default     = "CLUSTER_NAME"
 }
 
 variable "environment" {
   type    = string
-  default = "testing-env"
+  default = "ENV_NAME"
 }