Skip to content

Commit

Permalink
For now, don't test python 3.8 and 3.9 on macos github runners.
Browse files Browse the repository at this point in the history
  • Loading branch information
johndoknjas committed Apr 24, 2024
1 parent 452b44b commit d2ed7f8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- os: macos-latest
python-version: "3.8"
- os: macos-latest
python-version: "3.9"

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 4 additions & 0 deletions ideas.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
# Run pylint as a test in `tests.py`, where you assert certain error codes aren't raised.
For flake8, you can update the `run-tests` file to include more error codes there as well.

# https://github.com/actions/setup-python/issues/808
When python 3.8 and 3.9 reliably work on macos for github runners, remove the exclusion
of them in `run-tests.py`.

# Can include some linters mentioned here in your tests as well (e.g., bandit):
https://realpython.com/python-code-quality/

Expand Down

0 comments on commit d2ed7f8

Please sign in to comment.