mobile: Fix compiler warnings. (envoyproxy#29718)

This fixes the following compiler warnings: - `-Wsign-compare` - `-Wreturn-type` Signed-off-by: Fredy Wijaya <fredyw@google.com>
johnlanni · Sep 19, 2023 · b0b62e0 · b0b62e0
1 parent 5cf7598
commit b0b62e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/mobile/library/common/jni/android_network_utility.cc b/mobile/library/common/jni/android_network_utility.cc
@@ -148,6 +148,8 @@ envoy_cert_validation_result verify_x509_cert_chain(const std::vector<std::strin
   case CERT_VERIFY_STATUS_NOT_YET_VALID:
     return {ENVOY_FAILURE, SSL_AD_CERTIFICATE_UNKNOWN,
             "AndroidNetworkLibrary_verifyServerCertificates failed: not yet valid."};
+  default:
+    PANIC_DUE_TO_CORRUPT_ENUM
   }
 }
 

diff --git a/mobile/library/common/jni/jni_utility.cc b/mobile/library/common/jni/jni_utility.cc
@@ -370,7 +370,7 @@ std::vector<MatcherData> javaObjectArrayToMatcherData(JNIEnv* env, jobjectArray
 
   JavaArrayOfByteToString(env, static_cast<jbyteArray>(env->GetObjectArrayElement(array, 0)),
                           &cluster_name_out);
-  for (int i = 1; i < len; i += 3) {
+  for (size_t i = 1; i < len; i += 3) {
     std::string name;
     std::string type_as_string;
     std::string value;