This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
3324: Changed using of DefaultPatientTemplateService service bean #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwargulak
approved these changes
Jun 25, 2024
pwargulak
suggested changes
Jun 25, 2024
| @@ -170,6 +170,6 @@ private boolean isPatientTemplatesShouldNotBeCreated(String gpKey) { | |||
| } | |||
|
|
|||
| private DefaultPatientTemplateService getDefaultPatientTemplateService() { | |||
| return Context.getService(DefaultPatientTemplateService.class); | |||
| return Context.getRegisteredComponent("clfMultiProjectDefaultPatientTemplateService", DefaultPatientTemplateService.class); | |||
There was a problem hiding this comment.
Is the bean name required?
Do I understand correctly? There is a default implementation of DefaultPatientTemplateService, then there is another implementation of DefaultPatientTemplateService which applies Multi-Project logic. The getService doesn't support 'service override', and getRegisteredComponent does - getRegisteredComponent returns correct bean?
There was a problem hiding this comment.
yes, in this place Context.getService(DefaultPatientTemplateService.class) always returns DefaultPatientTemplate service which is a default implementation. I had to pass concrete name of bean to obtain multi-project implementation of this service (that's why getRegisteredComponent has been used)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.