Minor accessibility issue #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in sdk of 16 but setting the content description instead is ok on 14. Talkback should now announce the divider as "country preference divier" instead of just saying "unlabeled"
darcishED
reviewed
Aug 3, 2022
darcishED
left a comment
darcishED
left a comment
There was a problem hiding this comment.
Why are making the default preferences to US?.. can't the user of the library choose the preference he/she wants?
otherwise, everything else LGTM.
Author
|
Hello I have removed the default US preference. No reason for it. Thank you |
darcishED
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to produce issue
It's possible to set the divider as skippable by Talkback but this requires bumping min sdk from 14 to 16