Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface, Send: add warning for sweep button fee overriddance #60

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Interface, Send: add warning for sweep button fee overriddance #60

merged 1 commit into from
Jul 9, 2024

Conversation

MarnixCroes
Copy link
Collaborator

@MarnixCroes MarnixCroes commented Jun 8, 2024 •
edited
Loading

Issue that comes up a lot for users, so mention it in the docs
image

@MarnixCroes
Copy link
Collaborator Author

I'm aware of joinmarket-webui/jam#761 / joinmarket-webui/jam#764

still good to add it to the docs

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Jun 9, 2024 •
edited
Loading

I'm aware of joinmarket-webui/jam#761 / joinmarket-webui/jam#764

still good to add it to the docs

Thanks @MarnixCroes! Yes, good to add it to the docs.
The issue/PR you linked is also still waiting for better suggestions on how to phrase it properly. I think we should be more precise on why it might lead to a higher-than-expected mining fee. What do you think?

@MarnixCroes
Copy link
Collaborator Author

@theborakompanioni
sorry for late reply.
I've added more info for clarification

@theborakompanioni theborakompanioni added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 9, 2024
theborakompanioni
theborakompanioni approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@theborakompanioni theborakompanioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Reminded me to make the max change fee setting configurable in Jam. Thanks again! 🙏

@MarnixCroes MarnixCroes merged commit 62dedb2 into joinmarket-webui:master Jul 9, 2024
@MarnixCroes MarnixCroes deleted the sweep-warning branch July 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theborakompanioni theborakompanioni theborakompanioni approved these changes

Assignees

@MarnixCroes MarnixCroes

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarnixCroes @theborakompanioni