Remove CharacterNameLegacyMode (#2753)

src/JoinRpg.Dal.Impl/Migrations/202408151446243_RemoveCharacterNameLegacyMode.cs

@@ -0,0 +1,17 @@
+namespace JoinRpg.Dal.Impl.Migrations
+{
+    using System.Data.Entity.Migrations;
+
+    public partial class RemoveCharacterNameLegacyMode : DbMigration
+    {
+        public override void Up()
+        {
+            DropColumn("dbo.ProjectDetails", "CharacterNameLegacyMode");
+        }
+
+        public override void Down()
+        {
+            AddColumn("dbo.ProjectDetails", "CharacterNameLegacyMode", c => c.Boolean(nullable: false));
+        }
+    }
+}

src/JoinRpg.DataModel/Projects/ProjectDetails.cs

@@ -22,12 +22,6 @@ public class ProjectDetails : IValidatableObject
     public bool AutoAcceptClaims { get; set; } = false;
     public bool EnableAccommodation { get; set; } = false;
 
-    /// <summary>
-    /// If true, character name is separate property of character, not bound to any field
-    /// and could be edited only by master
-    /// </summary>
-    [Obsolete("Not used any more, will be deleted soon")]
-    public bool CharacterNameLegacyMode { get; set; } = true;
     /// <summary>
     ///   Null = bound to player name
     ///   Other value = bound to that field

src/JoinRpg.Services.Impl/ProjectService.cs

@@ -32,13 +32,7 @@ public async Task<Project> AddProject(ProjectName projectName, string rootCharac
             AvaiableDirectSlots = 0,
         };
         MarkCreatedNow(rootGroup);
-#pragma warning disable CS0618 // Type or member is obsolete
-        var projectDetails = new ProjectDetails()
-        {
-            //Flag will be removed later, now it should always be false
-            CharacterNameLegacyMode = false,
-        };
-#pragma warning restore CS0618 // Type or member is obsolete
+
         var project = new Project()
         {
             Active = true,
@@ -47,7 +41,7 @@ public async Task<Project> AddProject(ProjectName projectName, string rootCharac
             ProjectName = projectName,
             CharacterGroups = [rootGroup,],
             ProjectAcls = [ProjectAcl.CreateRootAcl(CurrentUserId, isOwner: true),],
-            Details = projectDetails,
+            Details = new ProjectDetails(),
             ProjectFields = [],
         };
         MarkTreeModified(project);