리팩토링 순차적 진행

jojoldu · Nov 11, 2023 · e7c95d8 · e7c95d8
1 parent 44fc517
commit e7c95d8
Show file tree

Hide file tree

Showing 12 changed files with 46 additions and 22 deletions.
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/README.md b/posts/리팩토링/좋은함수만들기_코드배치/README.md
@@ -2,35 +2,37 @@
 
 ```ts
 export class ProductService {
-    async oldCreates(classes: ClassDto[]): Promise<ClassDto[]> {
+    async create_1 (createDtos: ProductCreateDto[]) {
         const promiseList = [];
-        const results = [];
-        for(const classItem of classes) {
-            const newClassEntity = classItem.toClassEntity(generateUuid());
+        const results: Product[] = [];
+        for(const dto of createDtos) {
+            const entity = dto.toEntity(generateId());
             const queryParams = [];
-        
-            const query = `INSERT INTO ${ CLASS_TABLE_NAME }` +
-                `(${ Object.keys(newClassEntity).map(k => convertCamelToSnakeName(k)) }) ` +
-                `VALUES ( ${convertUuidToBinParam()}, ${convertUuidToBinParam()}, ${convertUuidToBinParam()}, ?, ?, ?, ?, ?, ?, NOW(), NOW() )`;
-        
+
+            const query =
+            `INSERT INTO product (${ Object.keys(entity) }) `
+            + 'VALUES (?, ?, ?, ?, ?, NOW(), NOW() )';
+
             queryParams.push(
-                newClassEntity.id,
-                newClassEntity.categoryId,
-                newClassEntity.teacherId,
-                newClassEntity.nameHash,
-                newClassEntity.name,
-                newClassEntity.price,
-                newClassEntity.state,
-                newClassEntity.isDeleted,
-                newClassEntity.description
+                entity.id,
+                entity.name,
+                entity.price,
+                entity.status,
+                entity.description
             );
             promiseList.push(this.dbConnection.query(query, queryParams))
-            results.push(ClassDto.fromEntity(newClassEntity));
+            results.push(entity);
         }
-        
+
         await Promise.all(promiseList);
         return results;
-    };
+    }
+```
+
+관련 있는 변수들을 근처로 옮긴다.
+
+```ts
+
 ```
 
 ```ts

diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref1.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref1.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref2.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref2.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref3.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref3.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref4.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref4.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref5.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref5.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref6.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref6.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref7.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref7.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref8.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref8.png
diff --git a/posts/리팩토링/좋은함수만들기_코드배치/images/ref9.png b/posts/리팩토링/좋은함수만들기_코드배치/images/ref9.png
diff --git a/src/product/DbConnection.ts b/src/product/DbConnection.ts
@@ -1,5 +1,5 @@
 export class DbConnection {
-    async query(sql: string, params: string[]) {
+    async query(sql: string, params: any[]) {
         console.log(sql);
         return 1;
     }

diff --git a/src/product/ProductService.ts b/src/product/ProductService.ts
@@ -34,6 +34,28 @@ export class ProductService {
         await Promise.all(promiseList);
         return results;
     }
+
+    async create_2 (createDtos: ProductCreateDto[]) {
+        const entites = createDtos.map(dto => dto.toEntity(generateId()));
+
+        await Promise.all(entites.map(entity => {
+            const query =
+                `INSERT INTO product (${ Object.keys(entity) }) `
+                + 'VALUES (?, ?, ?, ?, ?, NOW(), NOW() )';
+
+            const params = [
+                entity.id,
+                entity.name,
+                entity.price,
+                entity.status,
+                entity.description
+            ];
+
+            return this.dbConnection.query(query, params);
+        }));
+
+        return entites;
+    }
 }
 
 export async function save(product: Product) {