Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feat: support \thanks in title page #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jolars
Copy link
Owner

@jolars jolars commented Mar 20, 2025

Closes #44.

@jolars jolars linked an issue Mar 20, 2025 that may be closed by this pull request
@jolars jolars changed the title (WIP) feat: support \\thanks in title page (WIP) feat: support \thanks in title page Mar 20, 2025
@jolars
Copy link
Owner Author

jolars commented Mar 20, 2025

It's trivial to just enable this feature again, but it doesn't look great by default and I am having a hard time customzing the appearance of the content of \@thanks. It seems to ignore \usebeamercolor etc. Maybe someone who's more of a latex wizard (nudge nudge, @samcarter) could help figure this out? I am not even 100% sure where it is defined. I see that beamer is employing various hacks around this, like here: https://github.com/josephwright/beamer/blob/fef8f1b049516cebfc2eda4ca34e64cf17e544ec/base/beamerbasetitle.sty#L55-L62.

\insertthanks is also I guess empty? Not sure why.

@jolars jolars marked this pull request as draft March 20, 2025 11:34
@jolars
Copy link
Owner Author

jolars commented Mar 20, 2025

Maybe you have some thoughts, @rezahousseini?

@samcarter
Copy link

I am not even 100% sure where it is defined.

It is defined in the format, see texdoc source2e for the definition.

@samcarter
Copy link

samcarter commented Mar 20, 2025

It seems to ignore \usebeamercolor etc.

Beamer does not make any special changes to \thanks. As it is basically just a footnote, you can adjust it's colour etc. the via normal footnote templates/colours/etc.

For example:

\setbeamercolor{footnote}{fg=green}
\setbeamercolor{footnote mark}{fg=red}

@jolars
Copy link
Owner Author

jolars commented Mar 20, 2025

Great, thanks a lot! I think I know how to deal with this then.

@rezahousseini
Copy link

cool very responsiv! looks good, as far as I know it's a footnote as samcarter mentioned

@@ -204,7 +204,7 @@
\fi
}
\def\titlepage{%
\usebeamertemplate{title page}
\usebeamertemplate{title page}\ifx\insertthanks\@empty\else\@thanks\fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\insertthanks isn't defined, no need to test. Maybe just keep the beamer definition of the title page? \def\titlepage{\usebeamertemplate*{title page}\@thanks}

@jolars
Copy link
Owner Author

jolars commented Mar 20, 2025 via email

@jolars
Copy link
Owner Author

jolars commented Mar 20, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the \thanks command in the titlepage
3 participants