-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) feat: support \thanks
in title page
#45
base: main
Are you sure you want to change the base?
Conversation
\\thanks
in title page\thanks
in title page
It's trivial to just enable this feature again, but it doesn't look great by default and I am having a hard time customzing the appearance of the content of
|
Maybe you have some thoughts, @rezahousseini? |
It is defined in the format, see |
Beamer does not make any special changes to For example:
|
Great, thanks a lot! I think I know how to deal with this then. |
cool very responsiv! looks good, as far as I know it's a footnote as samcarter mentioned |
@@ -204,7 +204,7 @@ | |||
\fi | |||
} | |||
\def\titlepage{% | |||
\usebeamertemplate{title page} | |||
\usebeamertemplate{title page}\ifx\insertthanks\@empty\else\@thanks\fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\insertthanks
isn't defined, no need to test. Maybe just keep the beamer definition of the title page? \def\titlepage{\usebeamertemplate*{title page}\@thanks}
On Thu Mar 20, 2025 at 2:09 PM CET, rezahousseini wrote:
rezahousseini left a comment (jolars/moloch#45)
cool very responsiv! looks good, as far as I know it's a footnote as samcarter mentioned
Thanks for raising the issue. It seems like it was actually purposely disabled in metropolis, but I don't see why we shouldn't support this. I will wrap this up at the latest next week. It is a little more tricky that I thought since I need to make a temporary modification of the footnote-related commands, add a new beamer template for dealing with the thanks command, and figure out the spacing on the title page.
|
On Thu Mar 20, 2025 at 2:15 PM CET, samcarter wrote:
@samcarter commented on this pull request.
> @@ -204,7 +204,7 @@
\fi
}
\def\titlepage{%
- \usebeamertemplate{title page}
+ \usebeamertemplate{title ***@***.******@***.***\fi
`\insertthanks` isn't defined, no need to test. Maybe just keep the beamer definition of the title page? `\def\titlepage{\usebeamertemplate*{title ***@***.***}`
Thanks, yes, that's a good idea. I'll change it.
|
Closes #44.