Merge pull request #41 from jolicode/lyrixx-patch-1

Allow PHP 8.0
jolicode · Apr 7, 2021 · 860cd88 · 860cd88
2 parents fc18bec + 3b5ae9e
commit 860cd88
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -4,6 +4,7 @@ php:
     - 7.1
     - 7.2
     - 7.3
+    - 8.0
 
 env:
     global:

diff --git a/Tests/Command/GifOptimizerCommandTest.php b/Tests/Command/GifOptimizerCommandTest.php
@@ -19,15 +19,15 @@ class GifOptimizerCommandTest extends KernelTestCase
     private $prototypeGif;
     private $testGif;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
         $this->prototypeGif = __DIR__ . '/original.gif';
         $this->testGif = __DIR__ . '/gifs/test.gif';
     }
 
-    public function tearDown(): void
+    protected function tearDown(): void
     {
         parent::tearDown();
         copy($this->prototypeGif, $this->testGif);
@@ -52,7 +52,7 @@ public function testGifIsResizedToExpectedWidth()
         try {
             $this->getOutputForCommand('jolicode:gifexception:optimize', $args, $options);
         } catch (CommandNotFound $e) {
-            $this->markTestSkipped(sprintf('Gif optimizer tool is not executable'));
+            $this->markTestSkipped('Gif optimizer tool is not executable');
         }
 
         clearstatcache(true, $this->testGif);
@@ -72,7 +72,7 @@ public function testGifIsSmallerFileSize()
         try {
             $this->getOutputForCommand('jolicode:gifexception:optimize', $args);
         } catch (CommandNotFound $e) {
-            $this->markTestSkipped(sprintf('Gif optimizer tool is not executable'));
+            $this->markTestSkipped('Gif optimizer tool is not executable');
         }
 
         clearstatcache(true, $this->testGif);

diff --git a/Tests/FunctionalTest.php b/Tests/FunctionalTest.php
@@ -16,7 +16,7 @@
 
 class FunctionalTest extends WebTestCase
 {
-    public function test_it_does_not_display_gif_on_exception_page_if_the_bundle_is_not_enabled()
+    public function testItDoesNotDisplayGifOnExceptionPageIfTheBundleIsNotEnabled()
     {
         $client = static::createClient(['environment' => 'prod', 'debug' => true]);
 
@@ -30,7 +30,7 @@ public function test_it_does_not_display_gif_on_exception_page_if_the_bundle_is_
         self::assertFalse($image->hasAttribute('data-gif'));
     }
 
-    public function test_it_displays_gif_on_exception_page_if_the_bundle_is_enabled()
+    public function testItDisplaysGifOnExceptionPageIfTheBundleIsEnabled()
     {
         $client = static::createClient(['environment' => 'dev', 'debug' => true]);
 

diff --git a/Tests/KernelTestCase.php b/Tests/KernelTestCase.php
@@ -23,7 +23,7 @@ abstract class KernelTestCase extends BaseKernelTestCase
      */
     protected $tester;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         self::bootKernel();
 

diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
         ]
     },
     "require": {
-        "php": "^7.1.3",
+        "php": "^7.1.3 || ^8.0",
         "symfony/framework-bundle": "^4.4 || ^5.0",
         "symfony/twig-bundle": "^4.4 || ^5.0"
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ php: @@
         - 7.1
         - 7.2
         - 7.3
+        - 8.0
     env:
         global:
@@ Expand Down @@