Migrate sf 8 / type info #297
Open
+1,392
−2,007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/prepare-symfony8
branch
from
446d025 to
32ace2c
Compare
joelwurtz
force-pushed
the
feat/prepare-symfony8
branch
4 times, most recently
from
f74161d to
e25810c
Compare
joelwurtz
force-pushed
the
feat/prepare-symfony8
branch
from
e25810c to
8433eb4
Compare
joelwurtz
force-pushed
the
feat/prepare-symfony8
branch
from
69dd857 to
757bddb
Compare
Copilot finished reviewing on behalf of
joelwurtz
December 1, 2025 10:55
There was a problem hiding this comment.
Pull request overview
This PR migrates AutoMapper to Symfony 8 and PHP 8.4, introducing the new TypeInfo component as a replacement for the TypesMatching system. Key architectural changes include:
- Removal of
TypesMatchingclass and usage of Symfony'sTypeInfocomponent - Addition of type properties to source/target metadata
- Updated transformer factory interfaces to use metadata types directly
- Upgraded minimum PHP version to 8.4 and Symfony to 7.4/8.0
Reviewed changes
Copilot reviewed 140 out of 140 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Transformer/NullableTransformerFactoryTest.php | Removed setAccessible call that's still required for private property access |
| tests/Transformer/*TransformerFactoryTest.php | Updated tests to use TypeInfo API instead of TypesMatching |
| src/Transformer/*TransformerFactory.php | Refactored to accept source/target metadata directly instead of TypesMatching |
| src/Metadata/TypesMatching.php | Removed deprecated TypesMatching class |
| src/Metadata/*PropertyMetadata.php | Added Type property and withType() method |
| src/Extractor/*MappingExtractor.php | Updated to use separate source/target type extractors |
| composer.json | Updated dependencies to Symfony 7.4/8.0 and PHP 8.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| protected function setUp(): void | ||
| { | ||
| $this->isTargetNullableProperty = (new \ReflectionClass(NullableTransformer::class))->getProperty('isTargetNullable'); |
There was a problem hiding this comment.
The setAccessible(true) call has been removed, but accessing private properties still requires this call in PHP 8.1+. Without it, the test will fail with an error when trying to get the value of the private property isTargetNullable. This line should be restored to ensure the reflection property is accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to symfony 8, but it will deprecate a few things :
TypeInfocomponent