Conversation
Removed row-level security and policies for profiles, rooms, peers, and file_transfers tables.
This script enables row-level security on multiple tables and creates various policies for profiles, rooms, peers, and file transfers.
Added foreign key constraint from peers to profiles and created an index for better join performance.
This reverts commit 386bac7.
- Rename SQL migration files for clearer sequencing. - Update foreign key constraints in `peers` and `profiles` tables. - Ensure real-time updates for `peers` and `rooms` functionality. - Update README with new migration order and references.
Fix: Correct SQL Migration Dependency and Naming Errors
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Fix Next.js 16 build failures: migrate to proxy convention and handle missing env vars
Merge eslint.ignoreDuringBuilds into next.config.mjs #VERCEL_SKIP Co-authored-by: JOM <74537369+jomzxc@users.noreply.github.com>
…markdowns Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Consolidate documentation: create comprehensive README and CONTRIBUTING, remove redundant markdown files
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Add MIT License file to repository
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
…nality Add dynamic cursor styles for interactive elements
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive project reorganization and documentation update for WebDrop. It refactors the database setup scripts, improves configuration management, and significantly enhances project documentation.
- Reorganizes SQL migration scripts into a numbered sequence with clearer separation of concerns
- Adds graceful fallbacks for missing Supabase environment variables to enable builds without credentials
- Enhances documentation with comprehensive README, CONTRIBUTING guide, and issue templates
Reviewed Changes
Copilot reviewed 20 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/001_create_tables.sql |
Removed RLS policies from table creation script (moved to separate file) |
scripts/002_create_policies.sql |
New file containing all RLS policies extracted from table creation |
scripts/003_handle_new_user_trigger.sql |
New file for auto-profile creation trigger |
scripts/004_handle_updated_at_trigger.sql |
Renamed trigger to avoid naming conflicts with username sync trigger |
scripts/004_add_peers_profile_fkey.sql |
Deleted (migrated to script 005) |
scripts/005_add_peers_profile_fkey.sql |
New migration adding foreign key constraint with proper schema prefix |
scripts/006_enable_realtime.sql |
New file enabling realtime subscriptions on peers and rooms tables |
scripts/007_avatar_storage.sql |
New file setting up avatar storage bucket with RLS policies |
scripts/008_sync_username_trigger.sql |
Fixed trigger naming conflict by renaming and cleaning up old triggers |
proxy.ts |
Renamed exported function from middleware to proxy |
lib/supabase/client.ts |
Added environment variable fallbacks for build-time compatibility |
lib/supabase/server.ts |
Added environment variable fallbacks with warning messages |
lib/supabase/middleware.ts |
Added environment variable checks with graceful passthrough |
app/page.tsx |
Updated GitHub link to actual repository URL |
app/layout.tsx |
Removed unused font imports |
app/globals.css |
Added comprehensive cursor styles for interactive elements |
tsconfig.json |
Updated JSX transform and formatting, added dev types path |
README.md |
Complete rewrite with detailed architecture, setup, and troubleshooting |
CONTRIBUTING.md |
New comprehensive contributor guide |
LICENSE |
Added MIT license |
.gitignore |
Refined to allow .env.example while ignoring local env files |
SUPABASE_SETUP.md |
Removed (content integrated into README) |
SIGNALING_SETUP.md |
Removed (content integrated into README) |
.github/ISSUE_TEMPLATE/bug_report.md |
Added bug report template |
.github/ISSUE_TEMPLATE/feature_request.md |
Added feature request template |
Comments suppressed due to low confidence (1)
proxy.ts:4
- The function is named
proxybut this file appears to be the Next.js middleware entry point. Next.js middleware requires the exported function to be namedmiddleware, notproxy. This will break the middleware functionality. Either rename the function back tomiddlewareor ensure this file is properly imported and called from an actualmiddleware.tsfile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/supabase/server.ts
Outdated
| supabaseUrl || "https://placeholder.supabase.co", | ||
| supabaseAnonKey || "placeholder-anon-key", |
There was a problem hiding this comment.
Using placeholder credentials when environment variables are missing creates a security risk. The application will appear to work but will fail silently or unpredictably at runtime when making actual Supabase calls. Consider throwing an error during build time or at least during client creation to fail fast, rather than allowing the app to run with invalid credentials.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 25 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
proxy.ts:6
- The function is named
proxybut this file appears to be Next.js middleware (evidenced by theconfigexport with matcher). Next.js expects middleware files to export a function namedmiddleware. Renaming it toproxymay prevent Next.js from recognizing this as middleware. If this file is intended to be middleware.ts at the root, it should exportmiddleware, notproxy.
scripts/001_create_tables.sql:1 - The comment '-- Profiles policies' on line 10 (old numbering) is misleading because all the RLS policies have been removed from this file and moved to
002_create_policies.sql. This orphaned comment should be removed as it no longer describes the following code.
-- Create profiles table for user management
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: jomzxc <74537369+jomzxc@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Replace placeholder Supabase credentials with fail-fast error throwing
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 25 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
proxy.ts:6
- The function name 'proxy' does not accurately describe its purpose. In Next.js, this file serves as middleware and should export a function named 'middleware' for Next.js to recognize it. Renaming from 'middleware' to 'proxy' will break the middleware functionality unless there's a separate middleware.ts file that imports and re-exports this function. If this is intentional refactoring, ensure a middleware.ts file exists that exports this function as 'middleware'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge pull request #14 from jomzxc/develop
Description
This pull request includes the following updates:
Update GitHub Repository Link:
Dynamic Cursor Enhancements:
globals.css.Documentation Improvements:
Checklist