Add a missing null check since terminal properties can be null

Removes a redundant map lookup too. Fixes eclipse-cdt#617
jonahgraham · Nov 14, 2023 · b3cf860 · b3cf860
1 parent f5754e2
commit b3cf860
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/...pse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabTerminalListener.java b/...pse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabTerminalListener.java
@@ -127,13 +127,11 @@ private void updateTitle(final String title, final TerminalTitleRequestor reques
 			// Get the original terminal properties associated with the tab item
 			@SuppressWarnings({ "unchecked" })
 			final Map<String, Object> properties = (Map<String, Object>) item.getData("properties"); //$NON-NLS-1$
-			if (properties.containsKey(ITerminalsConnectorConstants.PROP_TITLE_DISABLE_ANSI_TITLE)) {
-				if (properties.get(
-						ITerminalsConnectorConstants.PROP_TITLE_DISABLE_ANSI_TITLE) instanceof Boolean disableAnsi) {
-					// Check if terminal title can be updated from ANSI escape sequence
-					if (disableAnsi && requestor == TerminalTitleRequestor.ANSI) {
-						return;
-					}
+			if (properties != null && properties
+					.get(ITerminalsConnectorConstants.PROP_TITLE_DISABLE_ANSI_TITLE) instanceof Boolean disableAnsi) {
+				// Check if terminal title can be updated from ANSI escape sequence
+				if (disableAnsi && requestor == TerminalTitleRequestor.ANSI) {
+					return;
 				}
 			}