Improve graph rendering in the default graphic mode#985
Open
proski wants to merge 1 commit intojonas:masterfrom
Open
Improve graph rendering in the default graphic mode#985proski wants to merge 1 commit intojonas:masterfrom
proski wants to merge 1 commit intojonas:masterfrom
Conversation
cca1c0a to
b696dc1
Compare
Using the same symbol for ordinary and boundary commits is misleading. Keep 'o' for boundary commits only, it's similar to other graphic modes. Use ACS_BULLET for ordinary commits, ACS_DIAMOND for merges and '@' for the initial commit, which is similar to the symbols used in the UTF-8 graphic mode. Update tests for the new graph symbols. ACS_BULLET corresponds to '~' in the alternative charset.
b696dc1 to
037d7f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.