Skip to content

Conversation

@jonasjucker
Copy link
Owner

No description provided.

@jonasjucker jonasjucker requested a review from Copilot April 18, 2025 15:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to integrate a job queue into the bot functionality to manage task scheduling such as basetime updates, caching plots, and broadcasting. Key changes include:

  • Removing old threading/asyncio functions and replacing them with job queue scheduling in bot startup.
  • Adding constants (JOBQUEUE_DELAY, DEFAULT_USER_ID) to support job queue behavior.
  • Modifying the PlotBot class to schedule periodic jobs for basetime override, basetime updates, caching, and broadcasting.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
main.py Removed legacy async/threading constructs and updated bot startup logic.
constants.py Introduced JOBQUEUE_DELAY and DEFAULT_USER_ID constants.
bot.py Replaced manual loop-based scheduling with job queue based scheduling.
Comments suppressed due to low confidence (1)

bot.py:342

  • Ensure that JOBQUEUE_DELAY (from constants.py) is appropriately tuned for the use case and that the use of run_once with an asynchronous callback (_send_plot_from_queue) is consistent with the synchronous expectations of the job queue scheduler.
context.job_queue.run_once(self._send_plot_from_queue,

Comment on lines +53 to 56
# we should not be here
sys.exit(1)


Copy link

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment '# we should not be here' together with sys.exit(1) could lead to confusion if bot.start() blocks indefinitely. Consider clarifying the intended control flow or removing unreachable code.

Copilot uses AI. Check for mistakes.
@jonasjucker jonasjucker merged commit 2fac1ab into main Apr 18, 2025
2 checks passed
@jonasjucker jonasjucker deleted the asyn branch April 18, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant