Handle DecompressionBombError when uploading a large image #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove python 3.6 from tox.ini, it's not supported any more
remove python 3.6 from github workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Expected result
The form should be invalid and user should be notified of error (invalid file)
Actual result
Since Pillow throws a
DecompressionBombErrorinstead of anAttributeError, this won't be caught inget_attrs()when trying to determine the image size. The view returns an error 500 instead of showing the invalid form. The user has no chance to see what's going wrong.Solution
When rendering the widget, any exception from the backend should be handled. This is what this PR does.
Notes
This PR is based on my other PR (#184), in order to let the workflow/automated test run.