-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
stefanpenner
commented
Nov 17, 2015
- cleaner tests
- hook up with BCW
- extract constants
- needs more tests
- after first build, js or css change re-generates SRI accordingly in index accordingly (needs to pass)
- test that it propagates ALL files forward.
- pending a BCW bug I think i found -> cacheInclude/exclude should be in listFiles listEntries ember-cli/broccoli-caching-writer#64
Looking good so far! |
4111cdb
to
75c4b42
Compare
npm v3
I realized, there is 1 important thing this will need to do. Propagate all otherFiles, even if the cache wasn't busted. An example would be. |
I haven't had any more time tonight, and tomorrow will be quite pressed with other tasks. Simplest thing i see if to opt out of caching and land this. @rwjblue when you wake up, let me know if you think of something else. I suspect. |
Latest update looks good to me. |
- only “vulnerability” is a devDep of a devDep, and the devDep is actually not affected.
Its worth noting, working on this gave me an idea to improve ergonomics of writing more advanced broccoli plugins. BCW and BF kinda feel awkward in all by the simplest scenarios. |
Thanks so much for all your hard work on @stefanpenner. Totally agree on the ergonomics point. |