Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Caching writer #8

Merged
merged 9 commits into from
Nov 17, 2015
Merged

Caching writer #8

merged 9 commits into from
Nov 17, 2015

Conversation

stefanpenner
Copy link
Collaborator

@rwjblue
Copy link
Collaborator

rwjblue commented Nov 17, 2015

Looking good so far!

@stefanpenner
Copy link
Collaborator Author

I realized, there is 1 important thing this will need to do. Propagate all otherFiles, even if the cache wasn't busted.

An example would be.
foo.png changes, although it doesn't trigger a build, we must still copy it. For this, I will need to add a small feature to BCW. Likely an additional hook, I need to think what that might be.

@stefanpenner
Copy link
Collaborator Author

I haven't had any more time tonight, and tomorrow will be quite pressed with other tasks. Simplest thing i see if to opt out of caching and land this. @rwjblue when you wake up, let me know if you think of something else. I suspect.

@rwjblue
Copy link
Collaborator

rwjblue commented Nov 17, 2015

Latest update looks good to me.

- only “vulnerability” is a devDep of a devDep, and the devDep is actually not affected.
@stefanpenner
Copy link
Collaborator Author

Its worth noting, working on this gave me an idea to improve ergonomics of writing more advanced broccoli plugins. BCW and BF kinda feel awkward in all by the simplest scenarios.

rwjblue added a commit that referenced this pull request Nov 17, 2015
@rwjblue rwjblue merged commit dd852dd into master Nov 17, 2015
@rwjblue rwjblue deleted the caching-writer branch November 17, 2015 17:21
@jonathanKingston
Copy link
Owner

Thanks so much for all your hard work on @stefanpenner. Totally agree on the ergonomics point.
I'll look at snyk and ESLint at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants