Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: docs for hnn-core integration #280

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

blakecaldwell
Copy link
Member

@blakecaldwell blakecaldwell commented Mar 22, 2021

Please merge this once a release has been created for the HNN-integration. Users will be directed to download the new version.

@blakecaldwell blakecaldwell mentioned this pull request Mar 22, 2021
11 tasks
@@ -9,12 +9,12 @@
- The command below will run a script to check for existing installations of prerequisites. If a compatible version is installed, it will say which steps can be skipped below.

```bash
curl -s "https://raw.githubusercontent.com/jonescompneurolab/hnn/master/installer/mac/check-pre.sh" | bash
curl -s "https://raw.githubusercontent.com/blakecaldwell/hnn/integration_docs/installer/mac/check-pre.sh" | bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this pointing to your fork?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you all are using this to test HNN GUI and check-pre.sh on master is for the old version. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, thanks for the detailed look! You must have been looking closely

@blakecaldwell blakecaldwell changed the title Docs for hnn-core integration [WIP] Docs for hnn-core integration Mar 22, 2021
Copy link
Collaborator

@jasmainak jasmainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakecaldwell feel free to merge when you're happy!

@blakecaldwell blakecaldwell changed the title [WIP] Docs for hnn-core integration Docs for hnn-core integration Mar 30, 2021
@blakecaldwell blakecaldwell changed the title Docs for hnn-core integration MRG: docs for hnn-core integration Mar 30, 2021
@blakecaldwell
Copy link
Member Author

Merging this is the switchover point for the integration. I'd like @jasmainak to make the switch when agreed upon by the group.

Prior to merging a new HNN GUI release should be made. See #283 for instructions on creating release assets that will be downloaded when following these instructions.

@@ -16,7 +16,7 @@ sudo yum -y install python34-setuptools
sudo easy_install-3.4 pip
pip3 install --upgrade matplotlib --user
pip3 install --upgrade nlopt scipy --user
pip3 install hnn-core
pip3 install https://api.github.com/repos/jonescompneurolab/hnn-core/zipball/master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can draft a minor release of hnn-core to go with the release of hnn ...

@blakecaldwell
Copy link
Member Author

Fixes #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants