MRG: get number of hist bins using ceil, not int #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tstop is not divisible by 5.0 (global, yuck!), the histogram that gets created is too small for the x-axis of the plots. Use ceil() to round up. Fixes jonescompneurolab#177
blakecaldwell
changed the title
jasmainak
reviewed
Apr 1, 2021
| @@ -90,7 +90,7 @@ def getdspk(spikes, extinputs, tstop): | |||
| haveinputs = True | |||
| for ty in dhist.keys(): | |||
| dhist[ty] = np.histogram(dhist[ty], range=(0, tstop), | |||
| bins=int(tstop / binsz)) | |||
| bins=ceil(tstop / binsz)) | |||
There was a problem hiding this comment.
why not just used the default bins of matplotlib?
There was a problem hiding this comment.
Good idea. Please contribute a PR for that that supercedes this.
|
This is a quick fix to #177. I think this whole file should be rewritten. |
|
Let's merge for now, we'll find proper fixes later |
|
Thanks @blakecaldwell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tstop is not divisible by 5.0 (global, yuck!), the histogram
that gets created is too small for the x-axis of the plots. Use
ceil() to round up.
Fixes #177