Additional fix for blank user agent string.

jonesiscoding · Dec 29, 2020 · 1308832 · 1308832
1 parent be56eb1
commit 1308832
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
     "retina"
   ],
   "homepage": "https://github.com/jonesiscoding/device",
-  "version": "4.0.7",
+  "version": "4.0.8",
   "suggest": {
     "deviscoding/poly-pointer": "Psuedo-Polyfill for (pointer:coarse). Easy support of touch devices."
   },

diff --git a/src/Device/Hints.php b/src/Device/Hints.php
@@ -287,14 +287,19 @@ protected function isUserAgentMatch($needle, &$regexMatches = null)
 
     foreach ($needles as $needle)
     {
-      if (!is_null($regexMatches))
+      if (null === $ua)
+      {
+        // Only if user agent is empty AND no needles are given.
+        return false;
+      }
+      elseif (!is_null($regexMatches))
       {
         if (!preg_match($needle, $ua, $regexMatches))
         {
           return false;
         }
       }
-      elseif (false === stripos($this->getUserAgent(), $needle))
+      elseif (false === stripos($ua, $needle))
       {
         return false;
       }