-
Notifications
You must be signed in to change notification settings - Fork 1
fix Dockerfile and install script #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Dockerfile to use pip3 instead of pip for Python package installations and adds an npm install instruction to the install script to ensure dependencies are installed before deployment.
- Changed
piptopip3in Dockerfile for Python 3 compatibility - Added npm install step in the deployment instructions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flare-worker/Dockerfile | Updated to use pip3 instead of pip for installing Python packages |
| install.sh | Added npm install instruction before npx wrangler deploy step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo " (Docker Desktop recommended: https://docs.docker.com/desktop/)" | ||
| echo " 2. cd flare-worker" | ||
| echo " 3. npx wrangler deploy" | ||
| echo " 3. npm install |
Copilot
AI
Jan 1, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing double quote on this echo statement. The line should end with a closing quote to properly terminate the string.
| echo " 3. npm install | |
| echo " 3. npm install" |
|
|
||
| # Install common packages for data processing and cloud access | ||
| RUN pip install --no-cache-dir boto3 requests pyiceberg pyarrow | ||
| RUN pip3 install --no-cache-dir boto3 requests pyiceberg pyarrow |
Copilot
AI
Jan 1, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RUN pip3 install --no-cache-dir boto3 requests pyiceberg pyarrow line installs multiple third-party packages from PyPI without any version pinning or integrity verification, which creates a persistent supply-chain risk: each rebuild may pull a new, potentially compromised version of these packages. An attacker who compromises one of these packages or the package distribution channel could achieve arbitrary code execution inside this container at build time or runtime. To reduce this risk, pin each dependency to specific versions (or a locked requirements file) and, where feasible, use mechanisms like hashes or a private mirror to ensure deterministic, integrity-checked installs.
change pip to pip3 in Dockerfile and
added npm install in install.sh