Closed
Conversation
package.json already specifies that node.js >=6 is required.
Author
|
Sorry I missed the fact that node 4 and 5 were still listed in travis-ci. package.json says node >= 6 is required so I've posted an additional commit to update travis-ci. If node.js 4 still needs to be supported then none of these changes can be merged. |
Author
|
Closing in favor of #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit updates
html-minifierto 4.0.0. This new version of html-minifier was semver-major due to it now requiring node.js 6.The second commit updates through2 and all dev dependencies. I did this as a separate commit in case you do not want the through2 upgrade it'll be easier to remove.
I verified locally that tests pass against node.js 6 for both commits.