Update index.d.ts (#21) · jonschlinkert/is-plain-object@6183667 · GitHub

Commit

Update index.d.ts (#21)

Browse files

Loading branch information

lifeiscontent authored Jul 21, 2020

1 parent 8dbd7a7 commit 6183667

index.d.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,3 +1,3 @@
  
    declare function isPlainObject(o: any): boolean;

    declare function isPlainObject(o: any): asserts o is object;

    export default isPlainObject;

6 comments on commit `6183667`

gr2m commented on `6183667` Jul 22, 2020 •

edited

Loading

This change is causing a TypeScript error now (TypeScript 3.9.7):

An expression of type 'void' cannot be tested for truthiness

Build: https://github.com/octokit/endpoint.js/pull/170/checks?check_run_id=897150799#step:5:15

I wonder what the motivation for that change was?

I'm by no means a TypeScript expert, but from what I've heard, the object type should be avoided

gr2m commented on `6183667` Jul 22, 2020

ping @lifeiscontent ☝🏼

Collaborator

TrySound commented on `6183667` Jul 22, 2020

@gr2m Do you have an idea how to implement proper object assert? I'm not typescript user so can't judge.

gr2m commented on `6183667` Jul 22, 2020

I think I'd just leave the boolean type. The method is not checking if o is an object, but if it's a plain object, I don't think you can reproduce that correctly with TypeScript

Collaborator

TrySound commented on `6183667` Jul 24, 2020

Published 4.1.1 with revert. Thanks for pointing to this.

gr2m commented on `6183667` Jul 24, 2020

Thanks a lot!

Please sign in to comment.