Bug fix #135
Merged
Bug fix #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d change cache duration to 30 seconds
…uce timeout in EconetDataCoordinator
… water heater lighter status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
econet300custom component, focusing on improving type annotations, adjusting timeout durations, and refining translation strings. The most important changes are listed below.Type Annotations and Logging Improvements:
custom_components/econet300/binary_sensor.py: Updated_sync_statemethod to include type annotation for thevalueparameter and added a type conversion to boolean. Additionally, improved logging messages for clarity.Timeout Adjustments:
custom_components/econet300/common.py: Reduced the timeout duration for theasyncio.timeoutcontext manager from 20 seconds to 10 seconds in the_async_update_datamethod.Translation String Updates:
custom_components/econet300/strings.json: Removed and reorganized several translation strings, including changes to the names of various components such as "Boiler pump" and "Water heater status." [1] [2] [3] [4]custom_components/econet300/translations/en.json: Similar updates to the English translation strings, ensuring consistency with the changes made instrings.json. [1] [2] [3] [4]custom_components/econet300/translations/pl.json: Updated Polish translation strings to reflect the changes made instrings.jsonanden.json. [1] [2] [3] [4]New Sensor Device Class:
custom_components/econet300/const.py: Added a new sensor device classtempCOSetto the list of temperature sensors.