forked from pblxptr/ecoNET-300-Home-Assistant-Integration
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
80 bug data for key data does not exist #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the
econet300
integration, focusing on refactoring the API methods, improving logging, and updating constant values. The most important changes include renaming methods for clarity, adding new API endpoints, and enhancing the logging and error handling mechanisms.Refactoring and Method Renaming:
get_params
tofetch_sys_params
to better describe its functionality and added more detailed logging. [1] [2]fetch_data
tofetch_reg_params_data
and added error handling for data fetching.Logging Improvements:
Constants and Configuration:
.vscode/settings.json
to include new words in the spell checker configuration.Error Handling:
Code Cleanup: