Skip to content

New feature: bb-jump: quickly navigate directly to any bm #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boruch-Baum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New feature: bb-jump: quickly navigate directly to any bm #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0264f0
New feature: bb-jump: quickly navigate directly to any bm
Boruch-Baum Apr 30, 2021
494b0ac
Fix support for other than the currently selected buffer
Boruch-Baum May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions bm.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,11 @@ over overlays with lower priority. *Don't* use a negative number."
"Face used to highlight bookmarks in the fringe if bookmark is persistent."
:group 'bm)

(defface bm-file-name-face '((t :foreground "yellow"))
"File name's face for display in function `bm-jump'.")

(defface bm-line-num-face '((t :foreground "green"))
"Line number's face for display in function `bm-jump'.")

(defcustom bm-annotate-on-create nil
"*Specify if bookmarks must be annotated when created.
Expand Down Expand Up @@ -555,6 +560,43 @@ before bm is loaded.")
(interactive)
(customize-group 'bm))

(defun bm-jump ()
"Jump directly to any bookmark.
Presents the bookmark list in the form of completion candidates
in the minibuffer for quick navigation."
(interactive)
(let* ((minibuffer-history '(""))
(bookmarks (bm-overlays-lifo-order 'all))
(file-line-width (bm-find-file-line-max-width bookmarks 'all))
(format-string (format "%%-%ds %%-%ds" file-line-width bm-annotation-width))
(elements
(mapcar
(lambda (bm)
(with-current-buffer (overlay-buffer bm)
(let ((annot (overlay-get bm 'annotation))
(line-num (number-to-string
(+ 1 (count-lines (point-min) (overlay-start bm))))))
(list (format "%s:%s"
(propertize (buffer-name) 'face 'bm-file-name-face)
(propertize line-num 'face 'bm-line-num-face))
(or annot "")
bm))))
bookmarks))
(candidates
(mapcar (lambda (elem)
(list (format format-string (nth 0 elem) (nth 1 elem))
(nth 2 elem)))
elements))
decision)
(while (or (not decision)
(zerop (length decision)))
(setq decision
(completing-read
"Jump to bookmark: "
(mapcar 'car candidates) nil t)))
(when (setq decision (assoc decision candidates))
(pop-to-buffer (overlay-buffer (cadr decision)))
(goto-char (overlay-start (cadr decision))))))
Copy link
Owner

@joodland joodland May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the bookmark is not available, but I don't like that jumping to a bookmark is done without using bm-goto() since there are more things happening in addition to the jump.


(defun bm-bookmark-annotate (&optional bookmark annotation)
"Annotate bookmark at point or the BOOKMARK specified as parameter.
Expand Down Expand Up @@ -624,7 +666,7 @@ Either the bookmark at point or the BOOKMARK specified as parameter."
If ANNOTATION is provided use this, and do not prompt for input.
Only used if `bm-annotate-on-create' is true.

TIME is useful when `bm-in-lifo-order' is not nil.
TIME is useful when `bm-in-lifo-order' is not nil.

if TEMPORARY-BOOKMARK not nil,the bookmark will be removed
when `bm-next' or `bm-previous' navigate to this bookmark."
Expand Down Expand Up @@ -687,7 +729,7 @@ EV is the mouse event."
(mouse-set-point ev)
(bm-toggle)))


(defun bm-modeline-info nil
"Display information about the number of bookmarks in the
current buffer. Format depends on `bm-modeline-display-total' and
Expand Down