-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.1] fix cli scheduler:run breaks if --live-site does not end with / #42864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Sven Schultschik <sven@schultschik.de>
Signed-off-by: Sven Schultschik <sven@schultschik.de>
|
composer update is unrelated. Beside that a url starts always with a slash so a live site looks always like https://example.com/ the last / is the identifier of the location. But I don't care if others thinks it's ok then it can be merged (wouldn't do it in 4.x branch at least) |
|
This pull request has been automatically rebased to 5.3-dev. |
|
This pull request has been automatically rebased to 6.0-dev. |
|
This pull request has been automatically rebased to 6.1-dev. |
Pull Request for Issue #42859 .
Summary of Changes
Adding a check if SCRIPT_NAME starts with a / or if
HTTP_HOSTends with a /If both checks are false add a / to prevent invalid URLs
Testing Instructions
This line fails
php cli/joomla.php scheduler:run -i 1 --live-site 'http://localhost:43000'
number 1 is the rotate Logs task, but it happens with any other as well
for testing this framework PR is needed as well joomla-framework/application#123
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Successful run
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed