Skip to content

Conversation

@svanschu
Copy link
Contributor

Pull Request for Issue #42859 .

Summary of Changes

Adding a check if SCRIPT_NAME starts with a / or if HTTP_HOST ends with a /
If both checks are false add a / to prevent invalid URLs

Testing Instructions

This line fails
php cli/joomla.php scheduler:run -i 1 --live-site 'http://localhost:43000'

number 1 is the rotate Logs task, but it happens with any other as well

for testing this framework PR is needed as well joomla-framework/application#123

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

Successful run

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: Sven Schultschik <sven@schultschik.de>
Signed-off-by: Sven Schultschik <sven@schultschik.de>
@HLeithner
Copy link
Member

composer update is unrelated. Beside that a url starts always with a slash so a live site looks always like https://example.com/ the last / is the identifier of the location. But I don't care if others thinks it's ok then it can be merged (wouldn't do it in 4.x branch at least)

@HLeithner HLeithner changed the title fix cli scheduler:run breaks if --live-site does not end with / [4.4] fix cli scheduler:run breaks if --live-site does not end with / Apr 24, 2024
@HLeithner HLeithner changed the base branch from 4.4-dev to 5.3-dev November 15, 2024 13:53
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:21
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.0-dev.

@HLeithner HLeithner changed the title [4.4] fix cli scheduler:run breaks if --live-site does not end with / [6.0] fix cli scheduler:run breaks if --live-site does not end with / Mar 4, 2025
@rdeutz rdeutz removed the PR-5.3-dev label Mar 5, 2025
@HLeithner HLeithner changed the base branch from 6.0-dev to 6.1-dev August 31, 2025 11:59
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.1-dev.

@HLeithner HLeithner changed the title [6.0] fix cli scheduler:run breaks if --live-site does not end with / [6.1] fix cli scheduler:run breaks if --live-site does not end with / Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants