Fix: Banner clients accept duplicates #46239

harshkhatri8 · 2025-10-06T16:07:32Z

Pull Request for Issue #45603
Fixes #45603

Summary of Changes

-Updated ClientModel.php to prevent duplicate client names when using Save as Copy.
-Implemented automatic unique name generation: if a client with the same name exists, the system appends (2), (3), etc.
-Preserves the original Save as Copy functionality without breaking existing save operations.

Testing Instructions

-Go to Components → Banners → Clients in Joomla Administrator.
-Select an existing client,.
-Click Save as Copy multiple times.
-Verify that each new client is created with a unique name:
-Confirm that no duplicates are created in the database and all other save functionality works as expected.

Actual result BEFORE applying this Pull Request

-Clicking Save as Copy creates a client with the same name as the original, allowing duplicates.

Expected result AFTER applying this Pull Request

-Clicking Save as Copy automatically generates a unique client name, preventing duplicates while preserving the copy functionality.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

… duplicate record in Component -> Banners -> Clients

brianteeman · 2025-10-06T16:18:28Z

This is obviously not correct. With this pr you can never Save as copy so why keep the button. Please look at how Save as copy works elsewhere!

harshkhatri8 · 2025-10-06T16:48:09Z

This is obviously not correct. With this pr you can never Save as copy so why keep the button. Please look at how Save as copy works elsewhere!

Thanks for the feedback, @brianteeman. I see your point now — my current PR prevents Save as Copy from working as intended. I’ll update the PR so that:

Save / Save & Close still prevent duplicates.

Save as Copy will create a copy automatically, appending a suffix like it works if a client with the same name exists.

This should fix the original issue while keeping Joomla’s copy functionality intact. I’ll push an updated version soon.

… duplicate record in Component -> Banners -> Clients

harshkhatri8 · 2025-10-06T17:09:08Z

This is obviously not correct. With this pr you can never Save as copy so why keep the button. Please look at how Save as copy works elsewhere!

i have made all the necessary changes can you please now review it.

richard67 · 2025-10-06T17:26:41Z

administrator/components/com_banners/src/Model/ClientModel.php

+        /**
+     * Override save to prevent duplicate client names when saving as copy.


Suggested change

/**

* Override save to prevent duplicate client names when saving as copy.

/**

* Override save to prevent duplicate client names when saving as copy.

richard67 · 2025-10-06T17:26:50Z

administrator/components/com_banners/src/Model/ClientModel.php

+     *
+     * @return  boolean  True on success, false on failure.
+     *
+     * @since   5.3.5


Suggested change

* @since 5.3.5

* @since __DEPLOY_VERSION__

richard67 · 2025-10-06T17:30:21Z

administrator/components/com_banners/src/Model/ClientModel.php

+
+
+
+    /**
+ * Generate a unique client name if it already exists.
+ *
+ * @param string $name The original client name
+ *
+ * @return string Unique client name
+ */
+    protected function generateUniqueName($name)


Suggested change

/**

* Generate a unique client name if it already exists.

*

* @param string $name The original client name

*

* @return string Unique client name

*/

protected function generateUniqueName($name)

/**

* Generate a unique client name if it already exists.

*

* @param string $name The original client name

*

* @return string Unique client name

* @since __DEPLOY_VERSION__

*/

protected function generateUniqueName($name)

richard67 · 2025-10-06T17:33:28Z

@harshkhatri8 When you create a PR you should check how your changes look on GitHub: https://github.com/joomla/joomla-cms/pull/46239/files . Then you would see it has a bunch of code style issues.

richard67 · 2025-10-06T17:35:05Z

administrator/components/com_banners/src/Model/ClientModel.php

+    }
+
+
+
+


Remove the 4 empty lines 189 to 192.

richard67 · 2025-10-06T19:29:07Z

administrator/language/en-GB/com_banners.ini

 COM_BANNERS_WARNING_PROVIDE_VALID_NAME="Please provide a valid, non-blank name"
 COM_BANNERS_XML_DESCRIPTION="This component manages banners and banner clients."
+COM_BANNERS_CLIENT_ERROR_DUPLICATE_NAME="A client with this name already exists."
+


Suggested change

Remove redundant empty line.

Thanks for the review, @richard67!
I’ve applied all your suggested code style changes — fixed the docblocks, removed extra blank lines, and added @SInCE DEPLOY_VERSION.
The PR has been updated and is ready for another review. 👍

Language key should be in alpha order.

Thanks for the review @QuyTon!
I made all the suggested changes. Please check it and provide a feedback.

@SInCE

…extra blank lines, and added @SInCE DEPLOY_VERSION

QuyTon · 2025-10-07T14:23:21Z

administrator/components/com_banners/src/Model/ClientModel.php

 use Joomla\CMS\MVC\Model\AdminModel;
 use Joomla\CMS\Table\Table;
 use Joomla\CMS\Versioning\VersionableModelTrait;
+use Joomla\CMS\Language\Text;


Suggested change

use Joomla\CMS\MVC\Model\AdminModel;

use Joomla\CMS\Table\Table;

use Joomla\CMS\Versioning\VersionableModelTrait;

use Joomla\CMS\Language\Text;

use Joomla\CMS\Language\Text;

use Joomla\CMS\MVC\Model\AdminModel;

use Joomla\CMS\Table\Table;

use Joomla\CMS\Versioning\VersionableModelTrait;

Sort alpha order.

QuyTon · 2025-10-07T14:24:11Z

administrator/components/com_banners/src/Model/ClientModel.php

+    }
+
+
+
+    /**
+     * Generate a unique client name if it already exists.
+     *
+     * @param string $name The original client name
+     *
+     * @return string Unique client name
+     * @since   __DEPLOY_VERSION__


Suggested change

}

/**

* Generate a unique client name if it already exists.

*

* @param string $name The original client name

*

* @return string Unique client name

* @since __DEPLOY_VERSION__

}

/**

* Generate a unique client name if it already exists.

*

* @param string $name The original client name

*

* @return string Unique client name

* @since __DEPLOY_VERSION__

Thanks for the review @QuyTon!
I made all the suggested changes. Please check it and provide a feedback.

… suggested change

QuyTon · 2025-10-09T16:15:13Z

administrator/language/en-GB/com_banners.ini

 COM_BANNERS_UNLIMITED="Unlimited"
 COM_BANNERS_WARNING_PROVIDE_VALID_NAME="Please provide a valid, non-blank name"
 COM_BANNERS_XML_DESCRIPTION="This component manages banners and banner clients."
+COM_BANNERS_CLIENT_ERROR_DUPLICATE_NAME="A client with this name already exists."


Please move language key in alpha order.

this one is also done now you can check it.

HLeithner · 2025-10-15T17:08:30Z

This pull request has been automatically rebased to 5.4-dev.

Fix: functionality of save as copy button to prevent it from creating…

7c30a27

… duplicate record in Component -> Banners -> Clients

joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Oct 6, 2025

harshkhatri8 closed this Oct 6, 2025

harshkhatri8 reopened this Oct 6, 2025

Fix: functionality of save as copy button to prevent it from creating…

abe0c7b

… duplicate record in Component -> Banners -> Clients

richard67 reviewed Oct 6, 2025

View reviewed changes

Fix: made all the changes suggested and fixed the Docblocks, removed …

08b459a

…extra blank lines, and added @SInCE DEPLOY_VERSION

QuyTon reviewed Oct 7, 2025

View reviewed changes

change the Language key and sort it in alpha order and also the other…

cd493a0

… suggested change

richard67 mentioned this pull request Oct 8, 2025

Banner clients accept duplicates #45603

Closed

QuyTon reviewed Oct 9, 2025

View reviewed changes

sort Language keys in alpha order

cccf92d

HLeithner changed the base branch from 5.3-dev to 5.4-dev October 15, 2025 17:08

HLeithner added the bug label Oct 15, 2025

richard67 added PR-5.4-dev and removed PR-5.3-dev labels Oct 16, 2025

		/**
		* Override save to prevent duplicate client names when saving as copy.

Uh oh!

Fix: Banner clients accept duplicates #46239

Are you sure you want to change the base?

Fix: Banner clients accept duplicates #46239

Conversation

harshkhatri8 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

brianteeman commented Oct 6, 2025

Uh oh!

harshkhatri8 commented Oct 6, 2025

Uh oh!

harshkhatri8 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richard67 commented Oct 6, 2025

Uh oh!

richard67 Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HLeithner commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

harshkhatri8 commented Oct 6, 2025 •

edited

Loading

harshkhatri8 commented Oct 6, 2025 •

edited

Loading

richard67 Oct 6, 2025 •

edited

Loading