Skip to content

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Nov 2, 2025

Pull Request for Issue #46162 .

Summary of Changes

set min value =0 for redis server port

Testing Instructions

see #46162

Actual result BEFORE applying this Pull Request

Invalid field: Redis server port

Expected result AFTER applying this Pull Request

redis connect

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review November 2, 2025 09:15
@richard67 richard67 added the bug label Nov 2, 2025
@richard67
Copy link
Member

What happens if you enter zero in the form and a server which is not a path to a socket but just a hostname and save?

Just am curious.

@alikon
Copy link
Contributor Author

alikon commented Nov 2, 2025

if you need to change the port to zero you probably already know what you are doing and why, there is already a default that works well for the majority of setups, right now you cannot use port zero as for xml, that's all

@richard67
Copy link
Member

if you need to change the port to zero you probably already know what you are doing and why, there is already a default that works well for the majority of setups, right now you cannot use port zero as for xml, that's all

@alikon Yes, that's ok, and I do not want to question this PR. I just was curious on what would happen, and maybe someone can test that.

@alikon
Copy link
Contributor Author

alikon commented Nov 2, 2025

on a standard setup i mean port 6379 (default) if you set zero as port you are not able to connect to the redis server, nothing different than before, this pr just allow to use port zero when you know why and when to do it

@wilsonge
Copy link
Contributor

wilsonge commented Nov 4, 2025

Is it too much to hide the port field if the connection url is a file ending in .sock? or we overdoing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants