Skip to content

Conversation

@LadySolveig
Copy link
Contributor

@LadySolveig LadySolveig commented Nov 2, 2025

Pull Request for Issue #46364 .

Summary of Changes

Introduce a new class (nav-active-open) for the default menu, allowing control over whether submenus are opened automatically on page load for the active menu item.

grafik grafik

Caution

This functionality should not be activated by default without an additional class for all default menus, as it may not be desirable in various other module positions.
Example - Cassiopeia menu position
grafik

Additionally updated the toggleSubMenu method to use optional chaining when setting the aria-expanded attribute, preventing errors if the target element is missing.

Testing Instructions

  • Install Blog-Sample-Data
  • Move the Main Menu Blog module to position sidebar-right
  • Switch the layout to Default

Step 1

  • Open site in frontend and select submenu entry Help -> Workflows

Step 2

  • Edit Main Menu Blog module - add class nav-active-open
  • Open site in frontend and select submenu entry Help -> Workflows

Important

For this to test an update of the media asset is required, please use the prebuilt packages or run npm install.

menu-fix.mp4

Actual result BEFORE applying this Pull Request

Should always be collapsed - with and without the class.

Expected result AFTER applying this Pull Request

Step 1
Submenu with menu entry Workflows should be always collapsed (without the class).
Step 2
Submenu with menu entry Workflows should stay open on new page load if Workflow is the current active item (with class set).

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed
    This pull request enhances the menu component's accessibility and behavior by adding a new setting to control submenu state on page load and improving error handling. The most important changes are grouped below:

* [6.0] README.md delete heavy development note
* Also clean heavy development note in README.txt
)

* Change major version to 7.0 for deprecation removals
* Add target version of editor buttons
* Revert 8 deprecations
* Update PHPStan baseline file
@LadySolveig LadySolveig added the bug label Nov 2, 2025
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Nov 2, 2025
@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on f231e7a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46397.

@ceford
Copy link
Contributor

ceford commented Nov 2, 2025

I have tested this item ✅ successfully on f231e7a

It works as described but I think it needs some documentation somewhere. Otherwise, how is anyone supposed to know that a style statement is needed to activate the behaviour?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46397.

@ceford
Copy link
Contributor

ceford commented Nov 2, 2025

Place for documentation: https://docs.joomla.org/J4.x:Submenus (?)

@LadySolveig
Copy link
Contributor Author

Place for documentation: https://docs.joomla.org/J4.x:Submenus (?)

Thank you @ceford 💚
Once it has been finally decided whether this is the right way to go, I will of course be happy to document it. Thank you for finding the right place.

@exlemor
Copy link

exlemor commented Nov 2, 2025

I have tested this item ✅ successfully on f231e7a

I was able to test this successfully :) (thanks @LadySolveig for the Layout: Default) hint...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46397.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46397.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 2, 2025
@richard67 richard67 added this to the Joomla! 6.0.1 milestone Nov 2, 2025
@Bodge-IT Bodge-IT modified the milestones: Joomla! 6.0.1, Joomla! 6.1.0 Nov 5, 2025
@Bodge-IT Bodge-IT changed the base branch from 6.0-dev to 6.1-dev November 5, 2025 08:08
@Bodge-IT
Copy link
Contributor

Bodge-IT commented Nov 5, 2025

More a feature than a bug fix, rebased to 6.1. Thanks @LadySolveig for addressing this issue so quickly

@Bodge-IT Bodge-IT changed the title [6.0] Fix default menu layout - submenu stay open on page load [6.1] Fix default menu layout - submenu stay open on page load Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.1-dev RTC This Pull Request is Ready To Commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.