-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Fix issues in language installer #46403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
I have tested this item ✅ successfully on 79c410a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
1 similar comment
|
I have tested this item ✅ successfully on 79c410a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
|
For the "automated update" box, I have already created a PR #46275 to address this issue. |
Good point, it was worse, the box was always visible, although the automated updates were disabled, after refreshing the page. It's not fixed. |
|
Reset to ‘Pending’ because there were changes to the code. @chmst and @tecpromotion, could you please test this PR again? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
|
I have tested this item ✅ successfully on b3e7ed8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
1 similar comment
|
I have tested this item ✅ successfully on b3e7ed8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403. |
Summary of Changes
When installing a language during installing Joomla! there are two issues:
This PR fixes the issues
Testing Instructions
Actual result BEFORE applying this Pull Request
Automated Updates box visible:

No Joomla Loader:

Expected result AFTER applying this Pull Request
No Automated Updates box:

Joomla Loader directly visible when pressing "Install Selected Language":
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed