Skip to content

Conversation

@bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Nov 4, 2025

Summary of Changes

When installing a language during installing Joomla! there are two issues:

  • the new "Automated Updates" box does not disappear when switching to the language installer
  • when the language installation is started, it seems like Joomla! is stuck, but it just installs the languages and then shows the joomla loader

This PR fixes the issues

Testing Instructions

  • Apply patch
  • Install Joomla!
  • Install aftwards before deleting the installation folder install some languages

Actual result BEFORE applying this Pull Request

Automated Updates box visible:
image

No Joomla Loader:
image

Expected result AFTER applying this Pull Request

No Automated Updates box:
image

Joomla Loader directly visible when pressing "Install Selected Language":

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst
Copy link
Contributor

chmst commented Nov 4, 2025

I have tested this item ✅ successfully on 79c410a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

1 similar comment
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 79c410a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2025
@heelc29
Copy link
Contributor

heelc29 commented Nov 5, 2025

For the "automated update" box, I have already created a PR #46275 to address this issue.
In your PR the check is missing if the element exists. This can happen if you disable the updates, then switch to languages and skip the installation. This will result in a javascript error.

@richard67 richard67 added the bug label Nov 5, 2025
@bembelimen
Copy link
Contributor Author

For the "automated update" box, I have already created a PR #46275 to address this issue. In your PR the check is missing if the element exists. This can happen if you disable the updates, then switch to languages and skip the installation. This will result in a javascript error.

Good point, it was worse, the box was always visible, although the automated updates were disabled, after refreshing the page. It's not fixed.

@muhme
Copy link
Contributor

muhme commented Nov 6, 2025

Reset to ‘Pending’ because there were changes to the code. @chmst and @tecpromotion, could you please test this PR again?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 6, 2025
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on b3e7ed8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Nov 6, 2025

I have tested this item ✅ successfully on b3e7ed8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

@chmst chmst added the RTC This Pull Request is Ready To Commit label Nov 6, 2025
@chmst
Copy link
Contributor

chmst commented Nov 6, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.

@chmst
Copy link
Contributor

chmst commented Nov 6, 2025

I am wondering why the language configuration scree is not closed. But this was already in oler versions.
@heelc29 thanks for your RP #46275 and your commit here. Are you all right with this PR or have you more concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PR-5.4-dev RTC This Pull Request is Ready To Commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants