[6.1] Refactor subform rendering with fieldsets support #46412
+73
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupByFieldset functionality added.
Summary of Changes
Setting groupByFieldset parameter in XML to true does not currently serve any purpose.
This change (without any other fieldset parameters) uses CSS grid display to group fields in a fieldset.
Additional parameters can be used with the fieldset(s) can be used to customise how the fields are grouped (e.g. use flex instead of grid).
Testing Instructions
Install the following plugins:
bfsubfieldtest1.zip
bfsubfieldtest2.zip
bfsubfieldtest3.zip
Actual result BEFORE applying this Pull Request
Go to plugin admin page.
Unexpected result - there is no difference between bfsubfieldtest1 and bfsubfieldtest2.
Expected result AFTER applying this Pull Request
Go to plugin admin page.
With bfsubfieldtest2 the the fields are now grouped by fieldset.
bfsubfieldtest3 illustrates how the appearance of fields grouped within fieldsets can be customised.
Link to documentations
The code in this pull request includes comments about the available fieldset attributes. These comments together with the example subform fields from bfsubfieldtest3 need to be included in the documentation.
Please select:
[*] Documentation link for docs.joomla.org:
Avanced Form Guide
Subform Form Field
[] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed