[6.0] php 8.4 fputcsv #46415
Closed
[6.0] php 8.4 fputcsv #46415
+11,921
−34,541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request joomla#45474 from Bodge-IT/upmerges/2025-05-14
…n XML (joomla#35184) * Update ModuletagField.php * Update HeadertagField.php * Phase 1 convert BRANCH to PSR-12 * Phase 2 convert BRANCH to PSR-12 ---------
* Revert "[6.0] Removing CMS Input package (joomla#42890)" This reverts commit 1be1415. * Move input classes to compatibility plugin * Update Compat.php * cs * more cs * Move back to libraries * move to if * path only ---------
Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Restore class aliases from compat 5 plugin * Relocate files from joomla#44925 --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net>
…" (joomla#45479) This reverts commit cb6cb1d.
Updating code changed in joomla#44090 to latest method
Not required for 6.0 release
…teps.ini Not required for 6.0
Merge pull request joomla#45511 from Bodge-IT/upmerges/2025-05-21
Merge pull request joomla#45526 from Bodge-IT/upmerges/2025-05-25 Pre -alpha prep.
* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/src/Extension/Compat6.php * Restore class aliases from compat 5 plugin * Relocate files from joomla#44925 * Apply language string improvement from review suggestion Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/src/Extension/Compat6.php Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Fix wrong folder in uninstallation of compat (5) plugin. --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard.fath@t-online.de> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
…la#45462) * Add deleted files and folders 2025-05-11 * Add deleted files from PR 45480 and update SQL scripts * Add exceptions to deleted_file_check * More exceptions for files deleted by plugin uninstallation
* Create tada.txt * Delete build/media_source/com_guidedtours/images/6_0/cassiopeiacolors.jpg * Add files via upload * Delete build/media_source/com_guidedtours/images/6_0/tada.txt * Add new image file * Rename cassiopeiacolors.jpg to cassiopeiacolors_old.jpg * Image with new size * Delete build/media_source/com_guidedtours/images/6_0/cassiopeiacolors_old.jpg
… tag name instead of the tag id (joomla#46174) * update sql * [CMS PR 46174] Update the update SQL scripts and for new installations supports.sql (#21) * Names quotes for column names * Remove some tabs * Use separate lines for closing brackets * Fix SQL error "operator does not exist" * Append only once to array * Update supports.sql for new installations
* Remove wrong unique constraint from "#__ucm_content" table on PostgreSQL * Rename 6.0.0-2025-10-11.sql to 6.0.0-2025-10-12.sql * Rename 6.0.0-2025-10-12.sql to 6.0.0-2025-10-10.sql
* Fix version history * CS * Fix hardcoded table name * Add field for new installation * Update administrator/components/com_admin/sql/updates/postgresql/6.0.0-2025-10-11.sql * Update administrator/components/com_admin/sql/updates/mysql/6.0.0-2025-10-11.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Prevent data lost when restore from version history created prior to Joomla 6 * Update administrator/components/com_admin/sql/updates/postgresql/6.0.0-2025-10-11.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Add field for new installation * Make phpstan happy * Update libraries/src/Versioning/VersionableModelTrait.php Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com> * Only store item real data into history * Revert "Only store item real data into history" * Avoid random column could not be null when restore from version history * Mark the history record not created by VersionableModelTrait as legacy * Fix warning for subform fields on compare view * Code simplify, thanks Richard * Move merge data logic to trait to make it easier for third party integration if not call parent::save * Use new way for saving category version history * Use new way to store version history for Tags * Prevent Version plugin save history for for Content, Banner, Contact * Use right context for category * Fix current version not detected properly on history view
Merge pull request joomla#46350 from richard67/6.0-dev-upmerge-2025-10-22
* Update create-translation-pull-request-v6.yml * Language update
Member
|
@brianteeman Shouldn't that be fixed in 5.4-dev (and then be merged up into 6.0-dev by RMs)? The issue applies to 5.4-dev, see https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php#L113 . |
brianteeman
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo and
rdeutz
as code owners
Contributor
Author
|
cant downgrade on a rebase - new pr #46423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
33 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
In PHP 8.4, not passing the $escape parameter emits a deprecation notice. Passing the $escape parameter explicitly avoids the deprecation notice.
Testing Instructions
Using php 8.4 go to action logs and export, Check the export
Actual result BEFORE applying this Pull Request
Deprecation notice
<b>Deprecated</b>: fputcsv(): the $escape parameter must be provided as its default value will change in <b>D:\repos\j6\administrator\components\com_actionlogs\src\Controller\ActionlogsController.php</b> on line <b>113</b><br />Expected result AFTER applying this Pull Request
No deprecation notice
Reference https://php.watch/versions/8.4/csv-functions-escape-parameter
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed