fix: restore caching and data loading in FormFactory and UserFactory (#46369) #46420
+176
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oomla#46369) Signed-off-by: sshekhar563 <shekharsiddhant93@gmail.com>
Member
|
Please create a new caching factory. This here is a bc break. That's why we intended interfaces to abstract different logic. |
…e consistency Implements caching and data loading to replace deprecated getInstance() behavior. Code formatted to Joomla coding standards. Signed-off-by: sshekhar563 <shekharsiddhant93@gmail.com>
Fixes joomla#46369 Signed-off-by: sshekhar563 <shekharsiddhant93@gmail.com>
sshekhar563
force-pushed
the
fix/getinstance-caching
branch
from
16725d9 to
fe468e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46369
This PR restores the caching and data-loading behavior that was lost when
the
getInstance()methods were removed from the core classes.Changes
FormFactory
private static array $forms)clearCache()for tests/runtime reloadsUserFactory
private static array $cache)clearCache()for testing and runtime reloadsBenefits
Form::getInstance()and
User::getInstance()implementations.Testing Instructions
FormFactory::createForm()multiple times with the same name — ✅ should return the same instance.UserFactory::loadUserById()orloadUserByUsername()repeatedly — ✅ should only query DB once.