-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.1] make media action crop aspect ratio configurable #46421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hans2103
wants to merge
10
commits into
joomla:6.1-dev
Choose a base branch
from
hans2103:feature/6.1-media-action-crop-aspect-ratio
base: 6.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[6.1] make media action crop aspect ratio configurable #46421
hans2103
wants to merge
10
commits into
joomla:6.1-dev
from
hans2103:feature/6.1-media-action-crop-aspect-ratio
+507
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
brianteeman
reviewed
Nov 7, 2025
Co-authored-by: Brian Teeman <brian@teeman.net>
Member
|
Nice, would be cool to default it with the existing values, so we can remove them when not needed. |
Contributor
Author
@laoneo that has been taken care of.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Language Change
This is for Translators
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-6.1-dev
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for no issue
Summary of Changes
This PR will add a subform to plugin media-action/crop to give you the option to configure your own aspect-ratios.
With this PR merged I am able to create a own set of aspect ratios.
Testing Instructions
Go To System > Plugins > Media-Action = Crop and notice the lack of options
Go To Content > Media ... select the three dots of an image and press "Edit". Open the dropdown at Aspect-Ratio and notice the presence of a pre-defined set of aspect-ratios
Apply the PR
npm run build:jsto compile newly added jsGo To System > Plugins > Media-Action = Crop and notice the availability of an aspect-ratio-calculator and a subform to add / remove / edit aspect-ratio options. Add, remove and edit aspect ratios.
Save the changes
Go To Content > Media ... select the three dots of an image and press "Edit". Open the dropdown at Aspect-Ratio and notice the changed set of aspect ratios
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed