-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.1] Cache Control: allow caching for Content views #46486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
Conversation
|
I have tested this item ✅ successfully on 071936c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46486. |
|
looks like the wrong approach for the linked issue. Also could lead to unexpected caching on frontend proxies for random content for example in random image module. my suggestion would be to remove the no-store from the default caching policy and only add it if the user is logged in. |
|
+1 about what @HLeithner said. @alikon I am not saying that Caching article would be a bad thing, but in order to make Joomla pages BFCache elgible it would be sufficient to remove only |
|
Currently we have only On/Off option for caching and nothing in between. When we remove What I suggest is to allow the cache for all "static views" (article listing, categories etc). |
no-store is not needed for normal We remove the Technically I should/could add a |
|
@Fedik @HLeithner I don't think that this can be done anywhere else but the template. The reason: a page could have a component without a form but the footer, or any other template position, might have a contact us form or something similar. My point is that only after laying out the page a decision on the caching could be done safely |
Technically I would set the "no-store" to false and allow the view, or what ever doesn't want it disabled to set it, the cache control in the application is wrong anyway, it would be in the document that at least knows more about what happens to the output then the application. |
|
I do not agree. To cache or not to cache is decisions for content providers. In our case it is a Component and then Modules. |
|
then you need a way to tell the application layer from the view or model if caching and what kind of caching. |


Pull Request for Issue #45403.
Summary of Changes
Cache Control: allow caching for Content views: articles, categories etc
Testing Instructions
Check browser dev. console network tab for the response for the page HTML of any article.
Also check that Content views works as before.
Actual result BEFORE applying this Pull Request
There is
cache-controlwithno-store, no-cache ...Expected result AFTER applying this Pull Request
There is no
cache-controlLink to documentations
Please select: