-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Load extension language for Action Logs - Latest module #46540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
Lines 78 and 79 in the PR are the same as the lines in the existing file? This is the original installation administrator/components/com_actionlogs//tmpl/actionlogs/default.php: |
|
@dmb0058 Yes, that's right. But administrator/components/com_actionlogs//tmpl/actionlogs/default.php is for component, the module does not have that similar lines and I believe that's the reason causing the issue. Could you check to see if the change in this PR address your issue? |
|
Ahh I see, sorry. I noticed that administrator/modules/mod_latestactions/tmpl/default.php doesn't have the ActionHelper lines but I was looking at the wrong place for the PR (github_newbie :)) I applied the patch and it works perfectly - thank you 🥇 |
|
Great. Could you please go to https://issues.joomla.org/tracker/joomla-cms/46540 and report your test result? We require two successful tests for each PR before it can be merged |
|
I have 42 actions logged throughout my component. Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported. After applying the patch each of the 42 translated strings are now correctly displayed with the username and action/item inserted. Is this enough to merge the PR? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540. |
|
I have tested this item ✅ successfully on 8b0ab38 Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported. After applying the patch each of the 42 translated strings are now correctly displayed with the username and action/item inserted. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540. |
|
I have tested this item ✅ successfully on 8b0ab38 Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported. After applying the patch each of the 12 translated strings are now correctly displayed with the username and action/item inserted. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540. |
Hello @dmb0058, there will need to be a 2nd test minimum for the maintainers to be able for the PR to be RTC and merged once the maintainers team evaluate/decide to include it in the next/appropriate release. Thank you for reporting the issue and for the test. |
Pull Request for Issue #46533.
Summary of Changes
Action Logs - Latest module does not load language for the extension associated with the log item and it could cause the message not being translated. This PR fixes that small issue
Testing Instructions
The issue only happens with third party extension as described here which unfortunately, not available for testing. So you can just make sure the module is still working as before with this PR applied. Plus, if you know code, you can do review the code change here with the code use in actions log component https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_actionlogs/tmpl/actionlogs/default.php#L79-L80
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed