Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Dec 7, 2025

Pull Request for Issue #46504 .

Summary of Changes

Respect the existing custom css

Testing Instructions

Actual result BEFORE applying this Pull Request

editor.css is ignored

Expected result AFTER applying this Pull Request

editor.css is NOT ignored, dark/light still functional

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Dec 7, 2025
Refactor content_css assignment for dark mode.
@exlemor
Copy link

exlemor commented Dec 7, 2025

Hi @dgrammatiko, thank you for your contribution number (too many to count ;) ).

Can you help me figure out what to test specifically for TinyMCE Dark Mode, or specific area of TinyMCE, etc as Dark Mode is a large topic? thank you very much :).

@dgrammatiko
Copy link
Contributor Author

Create an editor.css in the media/templates/site/cassiopeia/css. Check before and after. The issue is that for dark mode the editor is ignored

@exlemor
Copy link

exlemor commented Dec 7, 2025

media/templates/site/cassiopeia/css

Hi @dgrammatiko, I'm going to sound stupid but I already have an editor.css file in my media/templates/site/cassiopeia/css ( ( I didn't add it to be clear), it has 96 lines, and it's about 1kb... ?!

or are you saying that whether I create it or it's already there, it's being ignored in Dark Mode?

@dgrammatiko
Copy link
Contributor Author

As it was reported in the issue in 6.0.1 the file is ignored. Add some thing like a weird background color for the body and check if it is respected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants