[6.0] Remove use of deprecated dispatcher from the plugin constructor #46682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item 🔴 unsuccessfully on 3ba9fb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
I have tested this item ✅ successfully on 3ba9fb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
I have tested this item ✅ successfully on 3ba9fb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
I have tested this item ✅ successfully on 3ba9fb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46682. |
Contributor
|
shouldnt this be for 6.1 |
Contributor
|
@brianteeman #46683 for 6.1 |
Contributor
|
@Bodge-IT my point was that this isnt a bug fix therefore it should be for 6.1 and not a patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Same as #45644 for new plugin (fields note) of Joomla 6
Info: plugin fields number was fixed during upmerge commit f200a7d
Testing Instructions
Enable
Log Deprecated APIOpen view to add new custom field (
/administrator/index.php?option=com_fields&view=field&layout=edit&context=com_content.article)Check log file
administrator\logs\deprecated.phpActual result BEFORE applying this Pull Request
Log message
deprecated Passing an instance of Joomla\Event\DispatcherInterface to Joomla\CMS\Plugin\CMSPlugin::__construct() will not be supported in 7.0. Starting from 7.0 CMSPlugin class will no longer implement DispatcherAwareInterface. - [ROOT]\libraries\src\Plugin\CMSPlugin.php - Line 134Expected result AFTER applying this Pull Request
No log message
Link to documentations
Please select: